From 4590efe8bb9f5a1b31cecd2e886c4c945cb91746 Mon Sep 17 00:00:00 2001 From: Jay Sheen Date: Mon, 10 Nov 2025 13:41:27 +0900 Subject: [PATCH] Localize hardcoded Korean text in download-bottom-sheet and notice-detail MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Add translation keys for download bottom sheet messages - Replace hardcoded Korean text with translation function calls - Add error handling for empty notice detail response - Support multi-language functionality ๐Ÿค– Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- src/entities/common/ui/download-bottom-sheet.tsx | 8 ++++---- src/entities/support/ui/detail/notice-detail.tsx | 4 ++++ src/locales/en.json | 3 +++ src/locales/ko.json | 3 +++ 4 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/entities/common/ui/download-bottom-sheet.tsx b/src/entities/common/ui/download-bottom-sheet.tsx index aaa8293..c82f45a 100644 --- a/src/entities/common/ui/download-bottom-sheet.tsx +++ b/src/entities/common/ui/download-bottom-sheet.tsx @@ -57,7 +57,7 @@ export const DownloadBottomSheet = ({ }, 10); } else{ - snackBar('์‹ ์ฒญ ๋ฐฉ๋ฒ•์„ ์„ ํƒํ•˜์„ธ์š”'); + snackBar(t('common.selectRequestMethod')); } }; @@ -108,7 +108,7 @@ export const DownloadBottomSheet = ({ >
-

์‹ ์ฒญ ๋ฐฉ๋ฒ•์„ ์„ ํƒํ•˜์„ธ์š”

+

{t('common.selectRequestMethod')}

} - { selectedMode === DownloadSelectedMode.EMAIL && + { selectedMode === DownloadSelectedMode.EMAIL && (!optionsEmails || optionsEmails.length === 0) &&
-

๋“ฑ๋ก๋œ ๋ฉ”์ผ ์ •๋ณด๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค.
์ด๋ฉ”์ผ ์ธ์ฆ์ •๋ณด๋ฅผ ์‚ฌ์šฉ์ž๊ด€๋ฆฌ ๋ฉ”๋‰ด์—์„œ ์ถ”๊ฐ€ ํ›„ ์‹ ์ฒญํ•˜์„ธ์š”.

+

{t('common.noRegisteredEmail')}
{t('common.addEmailAuthInfo')}

} diff --git a/src/entities/support/ui/detail/notice-detail.tsx b/src/entities/support/ui/detail/notice-detail.tsx index 0dbbc2b..14fea3a 100644 --- a/src/entities/support/ui/detail/notice-detail.tsx +++ b/src/entities/support/ui/detail/notice-detail.tsx @@ -30,6 +30,10 @@ export const NoticeDetail = ({ seq: seq, }; noticeDetail(detailParams).then((rs: NoticeDetailResponse) => { + if(!rs || Object.keys(rs).length === 0){ + setDetailOn(false); + return; + } setResult(rs); }).catch((e: any) => { if(e.response?.data?.error?.message){ diff --git a/src/locales/en.json b/src/locales/en.json index 1b10fbd..5449acd 100644 --- a/src/locales/en.json +++ b/src/locales/en.json @@ -50,6 +50,9 @@ "errorOccurred": "An error occurred", "email": "Email", "kakao": "Kakao", + "selectRequestMethod": "Please select a request method", + "noRegisteredEmail": "No registered email information.", + "addEmailAuthInfo": "Please add email authentication information from the user management menu before applying.", "currency": { "krw": "KRW" } diff --git a/src/locales/ko.json b/src/locales/ko.json index e04a080..5fdee51 100644 --- a/src/locales/ko.json +++ b/src/locales/ko.json @@ -50,6 +50,9 @@ "errorOccurred": "์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒํ–ˆ์Šต๋‹ˆ๋‹ค", "email": "์ด๋ฉ”์ผ", "kakao": "์นด์นด์˜ค", + "selectRequestMethod": "์‹ ์ฒญ ๋ฐฉ๋ฒ•์„ ์„ ํƒํ•˜์„ธ์š”", + "noRegisteredEmail": "๋“ฑ๋ก๋œ ๋ฉ”์ผ ์ •๋ณด๊ฐ€ ์—†์Šต๋‹ˆ๋‹ค.", + "addEmailAuthInfo": "์ด๋ฉ”์ผ ์ธ์ฆ์ •๋ณด๋ฅผ ์‚ฌ์šฉ์ž๊ด€๋ฆฌ ๋ฉ”๋‰ด์—์„œ ์ถ”๊ฐ€ ํ›„ ์‹ ์ฒญํ•˜์„ธ์š”.", "currency": { "krw": "์›" }